-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set ProviderBoost capacity generated and fix tests #1947
Merged
shannonwells
merged 3 commits into
feat/capacity-staking-rewards-impl
from
feat/desired-capacity-boost-#1569
Apr 23, 2024
Merged
Set ProviderBoost capacity generated and fix tests #1947
shannonwells
merged 3 commits into
feat/capacity-staking-rewards-impl
from
feat/desired-capacity-boost-#1569
Apr 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set the amount of capacity generated by a provider boost to the final amount
shannonwells
force-pushed
the
feat/desired-capacity-boost-#1569
branch
from
April 22, 2024 18:02
c9623bd
to
bb2c4b2
Compare
shannonwells
force-pushed
the
feat/capacity-staking-rewards-impl
branch
from
April 22, 2024 18:02
0bf5c06
to
defdb39
Compare
shannonwells
commented
Apr 22, 2024
@@ -87,10 +87,11 @@ mod tests; | |||
/// storage migrations | |||
pub mod migration; | |||
pub mod weights; | |||
type BalanceOf<T> = | |||
pub(crate) type BalanceOf<T> = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
used in test only
aramikm
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good added some questions.
- Ran the test locally
shannonwells
added a commit
that referenced
this pull request
May 3, 2024
* set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking. * Also Fixes some tests broken from the last rebase with main. Closes #1569
shannonwells
added a commit
that referenced
this pull request
May 6, 2024
* set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking. * Also Fixes some tests broken from the last rebase with main. Closes #1569
shannonwells
added a commit
that referenced
this pull request
May 14, 2024
* set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking. * Also Fixes some tests broken from the last rebase with main. Closes #1569
shannonwells
added a commit
that referenced
this pull request
May 21, 2024
* set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking. * Also Fixes some tests broken from the last rebase with main. Closes #1569
shannonwells
added a commit
that referenced
this pull request
May 22, 2024
* set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking. * Also Fixes some tests broken from the last rebase with main. Closes #1569
shannonwells
added a commit
that referenced
this pull request
Jun 12, 2024
* set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking. * Also Fixes some tests broken from the last rebase with main. Closes #1569
shannonwells
added a commit
that referenced
this pull request
Jun 25, 2024
* set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking. * Also Fixes some tests broken from the last rebase with main. Closes #1569
shannonwells
added a commit
that referenced
this pull request
Jul 18, 2024
* set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking. * Also Fixes some tests broken from the last rebase with main. Closes #1569
shannonwells
added a commit
that referenced
this pull request
Jul 23, 2024
* set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking. * Also Fixes some tests broken from the last rebase with main. Closes #1569
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking.
Closes #1569
Discussion
To Verify
Since CI doesn't run for PRs against non-main branches, you can verify by running
make test
andmake start
if you like, and verify that tests all pass and the chain can run locally.Checklist
addedupdated