Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ProviderBoost capacity generated and fix tests #1947

Conversation

shannonwells
Copy link
Collaborator

@shannonwells shannonwells commented Apr 22, 2024

Goal

The goal of this PR is to set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking.

Closes #1569

Discussion

  • Also Fixes some tests broken from the last rebase with main.

To Verify

Since CI doesn't run for PRs against non-main branches, you can verify by running make test and make start if you like, and verify that tests all pass and the chain can run locally.

Checklist

  • Tests added updated

* Set the amount of capacity generated by a provider boost to the final
  amount
@shannonwells shannonwells force-pushed the feat/desired-capacity-boost-#1569 branch from c9623bd to bb2c4b2 Compare April 22, 2024 18:02
@shannonwells shannonwells force-pushed the feat/capacity-staking-rewards-impl branch from 0bf5c06 to defdb39 Compare April 22, 2024 18:02
@@ -87,10 +87,11 @@ mod tests;
/// storage migrations
pub mod migration;
pub mod weights;
type BalanceOf<T> =
pub(crate) type BalanceOf<T> =
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used in test only

@shannonwells shannonwells marked this pull request as ready for review April 22, 2024 23:14
Copy link
Collaborator

@aramikm aramikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good added some questions.

  • Ran the test locally

pallets/capacity/src/lib.rs Show resolved Hide resolved
pallets/capacity/src/lib.rs Show resolved Hide resolved
pallets/capacity/src/lib.rs Show resolved Hide resolved
@shannonwells shannonwells merged commit 358109d into feat/capacity-staking-rewards-impl Apr 23, 2024
@shannonwells shannonwells deleted the feat/desired-capacity-boost-#1569 branch April 23, 2024 20:53
shannonwells added a commit that referenced this pull request May 3, 2024
* set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking.
* Also Fixes some tests broken from the last rebase with main.
Closes #1569
shannonwells added a commit that referenced this pull request May 6, 2024
* set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking.
* Also Fixes some tests broken from the last rebase with main.
Closes #1569
shannonwells added a commit that referenced this pull request May 14, 2024
* set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking.
* Also Fixes some tests broken from the last rebase with main.
Closes #1569
shannonwells added a commit that referenced this pull request May 21, 2024
* set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking.
* Also Fixes some tests broken from the last rebase with main.
Closes #1569
shannonwells added a commit that referenced this pull request May 22, 2024
* set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking.
* Also Fixes some tests broken from the last rebase with main.
Closes #1569
shannonwells added a commit that referenced this pull request Jun 12, 2024
* set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking.
* Also Fixes some tests broken from the last rebase with main.
Closes #1569
shannonwells added a commit that referenced this pull request Jun 25, 2024
* set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking.
* Also Fixes some tests broken from the last rebase with main.
Closes #1569
shannonwells added a commit that referenced this pull request Jul 18, 2024
* set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking.
* Also Fixes some tests broken from the last rebase with main.
Closes #1569
shannonwells added a commit that referenced this pull request Jul 23, 2024
* set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking.
* Also Fixes some tests broken from the last rebase with main.
Closes #1569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants