Chores/update capacity benchmarks #1949 #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shannonwells
changed the base branch from
main
to
feat/capacity-staking-rewards-impl
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
github-actions
bot
added
metadata-changed
aramikm
reviewed
May 9, 2024
There was a problem hiding this comment.
I don't think this is correct. If you look at the on_initialize it consists of start_new_epoch_if_needed weights + start_new_reward_era_if_needed weights and inside each of them you are reusing T::WeightInfo::on_initialize() which makes this whole calculation kinda recursive!?
I think one way to fix this is to benchmark start_new_epoch_if_needed and start_new_reward_era_if_needed separately and maybe add them to get the weights for on_initialize
|
You are correct, I'd completely overlooked that it was doing that, and I'm not sure why it was set up that way. |
saraswatpuneet
approved these changes
May 13, 2024
shannonwells
added a commit
that referenced
this pull request
May 14, 2024
shannonwells
added a commit
that referenced
this pull request
May 21, 2024
shannonwells
added a commit
that referenced
this pull request
May 22, 2024
shannonwells
added a commit
that referenced
this pull request
Jun 12, 2024
shannonwells
added a commit
that referenced
this pull request
Jun 25, 2024
shannonwells
added a commit
that referenced
this pull request
Jul 18, 2024
shannonwells
added a commit
that referenced
this pull request
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to update the benchmark for
on_initializeto include the weight when a new RewardEra must be created.Closes #1949
Discussion
Separates the benchmark for on_initialize into two,
start_new_epoch_if_neededandstart_new_reward_era_if_needed. Those functions return the WeightInfo for their respective benchmarks.For
start_new_reward_era_if_needed, fills up the reward pool history and sets up the block and era to ensure that a new RewardEra will be created during the benchmark.Results: The new weights are a lot larger, 19M as compared to 4M, 6 reads as compared to 2, 4 writes as compared to 1, so there's some optimization work to be done. Filed new Issue #1967
Checklist