Capacity runtime api with list_unclaimed_rewards endpoint #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shannonwells
changed the base branch from
main
to
feat/capacity-staking-rewards-impl
shannonwells
requested review from
a team,
mattheworris,
enddynayn,
aramikm,
claireolmstead and
JoeCap08055
and removed request for
a team
shannonwells
changed the title
saraswatpuneet
approved these changes
Jul 19, 2024
enddynayn
reviewed
Jul 19, 2024
| earned_amount: 'Balance', | ||
| } | ||
| }, | ||
| runtime: { |
There was a problem hiding this comment.
Nice. By the way, do this show up in PolkadotUI now?
There was a problem hiding this comment.
It won't until it merges to main and is released, and I think you also have to post a PR with the updated release to PolkadotJS ui
mattheworris
approved these changes
Jul 19, 2024
Co-authored-by: Matthew Orris <1466844+mattheworris@users.noreply.github.com>
shannonwells
added a commit
that referenced
this pull request
Jul 23, 2024
# Goal The goal of this PR is to implement a capacity runtime api for the `list_unclaimed_rewards` endpoint. Following the current recommendation of Parity, there is no custom RPC matching this runtime API endpoint; instead, use state.call to access the endpoint. For examples using either Observable or APIPromise, see the e2e tests. Closes #1698
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to implement a capacity runtime api for the list_unclaimed_rewards endpoint.
Following the current recommendation of Parity, there is no custom RPC matching this runtime API endpoint; instead, use state.call to access the endpoint. For examples using either Observable or APIPromise, see the e2e tests.
Closes #1698
Checklist