Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some warnings emitted by new nightly rust #2129

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

shannonwells
Copy link
Collaborator

  • Add test and frequency-lint-check features to Cargo files
  • Add #[allow(dead_code)] to BlockWeight struct in frame-weight-template.hbs

Goal

The goal of this PR is to fix some warnings generated by an updated nightly rust version.

Closes #2009

Checklist

  • Spec version incremented?

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Aug 15, 2024
* Add #[allow(dead_code)] to BlockWeight struct in
  frame-weight-template.hbs
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Aug 16, 2024
@shannonwells shannonwells marked this pull request as ready for review August 16, 2024 16:33
@shannonwells shannonwells requested review from a team, mattheworris, enddynayn, aramikm, claireolmstead and JoeCap08055 and removed request for a team August 16, 2024 17:03
Copy link
Collaborator

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice!

@shannonwells shannonwells enabled auto-merge (squash) August 19, 2024 16:12
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Aug 19, 2024
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Aug 19, 2024
@shannonwells shannonwells merged commit 9e88342 into main Aug 19, 2024
27 checks passed
@shannonwells shannonwells deleted the chores/fix-warnings-#2009 branch August 19, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metadata-changed Metadata has changed since the latest full release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Warnings from Rust Nightly
4 participants