-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some warnings emitted by new nightly rust #2129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
github-actions
bot
added
metadata-changed
Metadata has changed since the latest full release
metadata-version-not-incremented
Metadata has changed since the latest full release, but the version has not been incremented
labels
Aug 15, 2024
* Add #[allow(dead_code)] to BlockWeight struct in frame-weight-template.hbs
shannonwells
force-pushed
the
chores/fix-warnings-#2009
branch
from
August 16, 2024 00:00
828e9e6
to
7d543e2
Compare
github-actions
bot
added
metadata-changed
Metadata has changed since the latest full release
and removed
metadata-changed
Metadata has changed since the latest full release
metadata-version-not-incremented
Metadata has changed since the latest full release, but the version has not been incremented
labels
Aug 16, 2024
shannonwells
requested review from
a team,
mattheworris,
enddynayn,
aramikm,
claireolmstead and
JoeCap08055
and removed request for
a team
August 16, 2024 17:03
saraswatpuneet
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
JoeCap08055
approved these changes
Aug 16, 2024
enddynayn
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 nice!
github-actions
bot
removed
the
metadata-changed
Metadata has changed since the latest full release
label
Aug 19, 2024
github-actions
bot
added
the
metadata-changed
Metadata has changed since the latest full release
label
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to fix some warnings generated by an updated nightly rust version.
Closes #2009
Checklist