Skip to content

Commit

Permalink
Unabbreviate THD in the Metric enum (#209)
Browse files Browse the repository at this point in the history
Metrics for Total Harmonic Distortion have been un-abbreviated:
- `METRIC_AC_THD_CURRENT` ->
`METRIC_AC_TOTAL_HARMONIC_DISTORTION_CURRENT`
- `METRIC_AC_THD_CURRENT_PHASE_[1|2|3]` ->
`METRIC_AC_TOTAL_HARMONIC_DISTORTION_CURRENT_PHASE_[1|2|3]`

Closes #177
  • Loading branch information
tiyash-basu-frequenz committed Mar 22, 2024
2 parents aeca5de + 8f06c7b commit 3a396c0
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
4 changes: 4 additions & 0 deletions RELEASE_NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@
`METRIC_AC_APPARENT_CURRENT` -> `METRIC_AC_CURRENT`
`METRIC_AC_APPARENT_CURRENT_PHASE_[1|2|3]` -> `METRIC_AC_CURRENT_PHASE_[1|2|3]`

- Metrics for Total Harmonic Distortion have been un-abbreviated:
`METRIC_AC_THD_CURRENT` -> `METRIC_AC_TOTAL_HARMONIC_DISTORTION_CURRENT`
`METRIC_AC_THD_CURRENT_PHASE_[1|2|3]` -> `METRIC_AC_TOTAL_HARMONIC_DISTORTION_CURRENT_PHASE_[1|2|3]`

## New Features

- Added a `Frequenz.api.common.v1.types.Decimal` type, compatible with
Expand Down
8 changes: 4 additions & 4 deletions proto/frequenz/api/common/v1/metrics/metric_sample.proto
Original file line number Diff line number Diff line change
Expand Up @@ -129,10 +129,10 @@ enum Metric {
METRIC_AC_REACTIVE_ENERGY_PHASE_3 = 70;

// AC harmonics
METRIC_AC_THD_CURRENT = 80;
METRIC_AC_THD_CURRENT_PHASE_1 = 81;
METRIC_AC_THD_CURRENT_PHASE_2 = 82;
METRIC_AC_THD_CURRENT_PHASE_3 = 83;
METRIC_AC_TOTAL_HARMONIC_DISTORTION_CURRENT = 80;
METRIC_AC_TOTAL_HARMONIC_DISTORTION_CURRENT_PHASE_1 = 81;
METRIC_AC_TOTAL_HARMONIC_DISTORTION_CURRENT_PHASE_2 = 82;
METRIC_AC_TOTAL_HARMONIC_DISTORTION_CURRENT_PHASE_3 = 83;

// General BMS metrics.
METRIC_BATTERY_CAPACITY = 101;
Expand Down

0 comments on commit 3a396c0

Please sign in to comment.