Improve select()-related exceptions
#283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
According to Python, users should not inherit from `BaseException`, so we just inherit from `channels.Error` instead. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
This exception is very niche, is not really intended to be caught by the users, as it should only happen when there is something really wrong. If there is any unexpected error during finalization, we just raise a `BaseExceptionGroup`, which will be automatically converted to a regular `ExceptionGroup` by Python if there are no `BaseException`s in the group. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
llucax
force-pushed
the
del-baseexception
branch
from
236d4d1
to
2bcebfd
Compare
|
Enabled auto-merge. |
shsms
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseExceptionSelectErrorGroupFixes #280.