Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import the LatestValueCache implementation from the Frequenz SDK #302

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Import the LatestValueCache implementation from the Frequenz SDK #302

merged 4 commits into from
Jul 1, 2024

Conversation

shsms
Copy link
Contributor

@shsms shsms commented Jun 27, 2024

This PR also adds an integration test for LatestValueCache.

@shsms shsms requested a review from a team as a code owner June 27, 2024 09:54
@shsms shsms requested a review from llucax June 27, 2024 09:54
@github-actions github-actions bot added part:tests Affects the unit, integration and performance (benchmarks) tests part:docs Affects the documentation labels Jun 27, 2024
@shsms
Import the LatestValueCache implementation from the Frequenz SDK
49110d7 
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
@shsms
Add an integration test for LatestValueCache
08b3e4e 
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
@shsms
Update release notes
e5f661e 
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
llucax
llucax reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would try to keep the user guide documentation up to date too, can you maybe add some high-level documentation with some example to the new private module docstring and expose it via docs/user-guide/receiving/caching.md maybe? Similar to this.

@llucax llucax added this to the v1.1.0 milestone Jun 28, 2024
@shsms
Add a user-guide entry for LatestValueCache
3e68eea 
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
@shsms
Copy link
Contributor Author

shsms commented Jun 28, 2024

can you maybe add some high-level documentation with some example

done

llucax
llucax approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! I think I could make sense to rename get() to value and make it a @property, but this can be discussed separately and done in a separate PR too, so approving anyways.

@shsms shsms added this pull request to the merge queue Jul 1, 2024
@llucax llucax mentioned this pull request Jul 1, 2024
Closed
@llucax
Copy link
Contributor

llucax commented Jul 1, 2024

Nice, thanks! I think I could make sense to rename get() to value and make it a @property, but this can be discussed separately and done in a separate PR too, so approving anyways.

Merged via the queue into frequenz-floss:v1.x.x with commit a90611c Jul 1, 2024
14 checks passed
@shsms shsms deleted the latest-value-cache branch July 1, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llucax llucax llucax approved these changes

Assignees
No one assigned
Labels
part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shsms @llucax