Remove TODOs #46
Merged
Remove TODOs #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
Marenz
previously approved these changes
May 7, 2024
llucax
added
the
type:tech-debt
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Make logs more consistent and use more appropriate log levels: * info for when streaming starts (it shouldn't happen that often) * warning for when streaming is interrupted by an error but we are going to retry * error when we exhausted the retries, so we are giving up We don't print a traceback anymore, as this will be inside the grpcio library and won't tell us much more than the error message itself. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
llucax
added
the
cmd:skip-release-notes
|
Skipping release notes because it is just a cosmetic change in logs. Rebased as I wasn't based on the current head, I also dropped a few commits that were already fixed in head. |
|
Enabled auto-merge. |
Marenz
approved these changes
May 7, 2024
Merged
via the queue into
frequenz-floss:v0.x.x
with commit May 7, 2024
7ace841
14 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part:codelabel