Improve type-checking for _grpchacks
#59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ChannelT` `TypeVar` was causing a lot of issues because the types in it would change dynamically depending on which grpc library is installed. This transpired to user code wanting to subclass `BaseApiClient` which is less than ideal (hacks should be kept internal). This commit improves this by adding a function to create a channel, which also avoids the need to create a lot of stub `grpcio` functions, and making `ChannelT` bound to an `AsyncContextManager[Any]` instead of the two specific channel classes we use. This interface is enought for the functionality we need from channels. This way the hacks don't leak to the type system, which was the main issue. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
github-actions
bot
added
part:tests
|
Added auto-merge. |
llucax
added
the
cmd:skip-release-notes
|
Skipping release notes as this affects an unreleased feature. |
daniel-zullo-frequenz
approved these changes
Jun 12, 2024
Merged
via the queue into
frequenz-floss:v0.x.x
with commit Jun 12, 2024
49aee99
15 of 16 checks passed
|
Oh, damn, I forgot about the typo in the commit message 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ChannelTTypeVarwas causing a lot of issues because the types in it would change dynamically depending on which grpc library is installed. This transpired to user code wanting to subclassBaseApiClientwhich is less than ideal (hacks should be kept internal).This PR improves this by adding a function to create a channel, which also avoids the need to create a lot of stub
grpciofunctions, and makingChannelTbound to anAsyncContextManager[Any]instead of the two specific channel classes we use. This interface is enough for the functionality we need from channels.This way the hacks don't leak to the type system, which was the main issue.