Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix credentials not passed or configured the CI workflow #286

Merged
merged 8 commits into from
Jul 3, 2024
Merged

Fix credentials not passed or configured the CI workflow #286

merged 8 commits into from
Jul 3, 2024

Commits on Jul 2, 2024

  1. Replace the old setup-git-user step with gh-action-setup-git 

    The new actions is also able to set credentials, and we add an example
on how to set credentials for projects that have private dependencies.

We also move the step to the beginning, in case the submodule
dependencies are private.

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
    @llucax
    llucax committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    3ff7691 View commit details
    Browse the repository at this point in the history

  2. Add a gh-action-setup-git step to every job doing a checkout 

    If we do a Git checkout, there is the chance that we also need to fetch
some private submodule we need credentials for.

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>

# ------------------------ >8 ------------------------
# Do not modify or remove the line above.
# Everything below it will be ignored.
#
# Conflicts:
#	tests_golden/integration/test_cookiecutter_generation/model/frequenz-model-test/.github/workflows/ci.yaml
    @llucax
    llucax committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    42fd90e View commit details
    Browse the repository at this point in the history

  3. Pass git credentials to the test-installation job 

    Credentials were not being passed to the docker build process, and the
installation test runs as part of the image builting, so it fails when
some `pip` dependency needs git credentials to be fetched.

This commit fixes this by passing the `.git-credentials` file generated
by the `frequenz-floss/gh-action-setup-git` action to the docker build
process.

Even when the produced docker image doesn't leave the GitHub runner,
this is not ideal because we are storing credentials in the docker
image, so eventually this job should be changed so the tests is done
in a running container instead of a docker image building process, but
for now is a good-enough workaround.

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
    @llucax
    llucax committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    5089837 View commit details
    Browse the repository at this point in the history

  4. Improve spacing of the test-installation job 

    Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
    @llucax
    llucax committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    655bb25 View commit details
    Browse the repository at this point in the history

  5. Add migration steps to the migration script 

    Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
    @llucax
    llucax committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    1907521 View commit details
    Browse the repository at this point in the history

  6. Apply the migration script to this repository 

    We'll remove the TODOs in the next commit.

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
    @llucax
    llucax committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    55922d4 View commit details
    Browse the repository at this point in the history

  7. Remove the TODOs from the migration 

    Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
    @llucax
    llucax committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    bef233c View commit details
    Browse the repository at this point in the history

  8. Update release notes 

    Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
    @llucax
    llucax committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    6195bc7 View commit details
    Browse the repository at this point in the history