-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SemVer broken by 2.10.0 release #172
Comments
Thanks for reporting and the detailed analysis. The possible solutions are also appreciated - even though fixing the breakage may cause more breakage with those who use 2.8 with HTTP1, that should be the minority and doing so should be preferred. A fix as proposed is in the works. |
validation log
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This crate documents itself as following SemVer:
rust-crates-index/CHANGELOG.md
Lines 1 to 6 in dba8b14
Per SemVer, migrating from
crates-index 2.8.0
tocrates-index 2.10.0
should only involve backwards-compatible changes. However,2.10.0
included #170 which migrated fromhttp 0.2
tohttp 1.0
. This is a breaking change, becausehttp
is exposed in the crate's public API. For example,crates_index::SparseIndex::parse_cache_response
takes anhttp::response::Response
as an argument.Specifically, this update broke users' ability to install
cargo-dl
(which usesSparseIndex::parse_cache_response
), which now fails with:Possible resolutions:
2.Y.Z
series. Then re-publish 2.10.0 / currentmaster
branch as 3.0.0.crates-index
follows SemVer from the changelog, and update the changelog for2.10.0
to document that it is a breaking release that migrates fromhttp 0.2
tohttp 1
.The text was updated successfully, but these errors were encountered: