Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to http 1 #170

Merged
merged 1 commit into from
May 15, 2024
Merged

Upgrade to http 1 #170

merged 1 commit into from
May 15, 2024

Conversation

fenhl
Copy link
Contributor

@fenhl fenhl commented May 15, 2024

This PR upgrades the http dependency to version 1. This allows directly converting from reqwest::Response to http::Response rather than manually building the response as shown in the example. Note that this conversion is only implemented for regular (async) responses, so the example (which uses reqwest::blocking) remains unchanged.

Byron
Byron approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, looks great!

I think last time I tried I couldn't figure out how to make it work with ureq, so it's interesting to see it's just behind a different feature toggle.

@Byron Byron merged commit eae6947 into frewsxcv:master May 15, 2024
2 checks passed
@fenhl fenhl deleted the http1 branch May 15, 2024 06:46
@str4d str4d mentioned this pull request May 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Byron Byron Byron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fenhl @Byron