Validate string values passed for enum arguments #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pigbug419
approved these changes
Aug 2, 2023
| @@ -254,7 +261,7 @@ def create( | |||
| "infrequest_log": logging, | |||
| **config, | |||
| } | |||
| if description: | |||
| if description is not None: | |||
There was a problem hiding this comment.
Is there any reason to change?
There was a problem hiding this comment.
This change considers the case when the value of description is "" (empty string).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Summary
This PR validates the string values passed for enum arguments of some SDK functions.
Motivation and Context
Several SDK functions get enum arguments but those enums are not exposed to users directly. For example, in the case of
Deployment.create,CloudTypeenum value should be passed to thecloudargument likecloud=CloudType.AWS, which means users have to import theCloudTypewithfrom PeriFlow.enums import Cloud.Instead of importing the enum types, this PR makes the SDK allow passing the proper string values and validating the value. (Of course, enum values are also allowed.)
Type of Change