Not raising error when valid tokenizer not found #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pigbug419
approved these changes
Aug 2, 2023
| @@ -32,6 +32,7 @@ | |||
| context_settings={"help_option_names": ["-h", "--help"]}, | |||
| add_completion=False, | |||
| callback=validate_cli_version, | |||
| pretty_exceptions_enable=False, | |||
There was a problem hiding this comment.
Why did you disable pretty exceptions?
There was a problem hiding this comment.
The pretty exception is too verbose and it displays too much info to users. By applying this change, it will show the normal Python traceback. Refer to https://typer.tiangolo.com/tutorial/exceptions/#disable-pretty-exceptions for more info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Summary
Type of Change
Specify the appropriate type of change and remove irrelevant options.