Skip to content

Commit

Permalink
Add test to agree on desired aligned behavior of ls for empty directo…
Browse files Browse the repository at this point in the history
…ries.
  • Loading branch information
hmeyer committed Dec 20, 2023
1 parent 378cae6 commit 5a03139
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion gcsfs/tests/test_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,6 @@ def test_pickle(gcs):
gcs.touch(a)
assert gcs.ls(TEST_BUCKET) == gcs2.ls(TEST_BUCKET)


def test_ls_touch(gcs):
assert not gcs.exists(TEST_BUCKET + "/tmp/test")

Expand All @@ -177,6 +176,14 @@ def test_ls_touch(gcs):
assert {d["name"] for d in L_d} == {a, b}


# DO NOT MERGE!
# Note: We assume this test will fail. Once it does in CI, we will update the code to make it pass.
# Only then can this PR be approved and merged.
def test_ls_empty_dir(gcs):
gcs.mkdir(TEST_BUCKET + "/test")
assert gcs.ls(TEST_BUCKET + "/test", False) == []


def test_rm(gcs):
assert not gcs.exists(a)
gcs.touch(a)
Expand Down

0 comments on commit 5a03139

Please sign in to comment.