Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Runtime.js to not always remove last argument #32

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vanesca88
Copy link

@vanesca88 vanesca88 commented Feb 1, 2023

Fixed a bug where if you used any Async method in a standard await function, it would always remove the last argument of the function you are trying to call (if you supplied any)
Which isn't supposed to happen.

This doesn't happen if you use the default Async method, via the water-fall method, where the function you are trying to call is embedded to the call itself.

Now supports both methods!

  1. Water-fall (call-back embedded)
  2. Standard await.

See the included test for an example. It crashes on the current Runtime.js.
But fixed on the pull request.

Fixed a bug where if you used any Async method in a standard await function, it would always remove the last argument of the function you are trying to call (if you supplied any)
Which isn't supposed to happen.

This doesn't happen if you use the default Async method, via the water-fall method, where the function you are trying to call is embedded to the call itself.

Now supports both methods!
1. Water-fall (call-back embedded)
2. Standard await.
There was a bug that didn't allow you to run execute multiple times, especially after something like a delay. A flag was being reset. Being able to run .execute multiple times is part of the charm.

Includes a test.
Run with "node fix2.js"
@vanesca88
Copy link
Author

Also fixed sandbox.js
There was a bug that didn't allow you to run execute multiple times, especially after something like a delay. A flag was being reset. Being able to run .execute multiple times is part of the charm.

Includes a test.
Run with "node fix2.js"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant