Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed data truncation for signed messages #6

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Fixed data truncation for signed messages #6

wants to merge 25 commits into from
+752 −81

Commits on Apr 14, 2016

  1. Fixed content truncation by looping through all packages and parsing … 

    …each packge. The parsed result then gets concatenated.
    Georg Koester committed Apr 14, 2016
    Configuration menu
    Copy the full SHA
    e7f98c0 View commit details
    Browse the repository at this point in the history

  2. Removed unnecessary variable declaration

    Georg Koester committed Apr 14, 2016
    Configuration menu
    Copy the full SHA
    35fe2c3 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2016

  1. Bug fix and hack to allow unsigning certain files 

    Most files could be unsigned, but some were failing. This commit successfully parses at least one example (received by email from Frank).
    Timo Gatsonides committed Jul 30, 2016
    Configuration menu
    Copy the full SHA
    6221838 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from tpjg/master 

    Bug fix and hack to allow unsigning certain files
    @geoko86
    geoko86 authored Jul 30, 2016
    Configuration menu
    Copy the full SHA
    b995b8d View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2019

  1. Correctly marshal degenerate certificates (fullsailor#7) 

    Fixes an issue where more than one certificate would not be marshalled correctly.
This is now tested against openssl

* correctly marshal degenerate certificates
* update DegenerateCertificates test
* add marshalCertificateBytes function and test against openssl
    @groob @msiebeling
    groob authored and msiebeling committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    43ffad5 View commit details
    Browse the repository at this point in the history

  2. AES-128-GCM support in Encrypt() and Decrypt() (fullsailor#8) 

    * Added AES-128-GCM support to Encrypt() and Decrypt()
    @hryx @msiebeling
    hryx authored and msiebeling committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    477c9f6 View commit details
    Browse the repository at this point in the history

  3. Fix signers without AuthenticatedAttributes 

    According to the specification, when AuthenticatedAttributes isn't included the pkcs7 content should be used.

Fixes fullsailor#9
    @fullsailor @msiebeling
    fullsailor authored and msiebeling committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    bcb2b81 View commit details
    Browse the repository at this point in the history

  4. Fix an unstaged git hunk. 

    From a676cd5
    @fullsailor @msiebeling
    fullsailor authored and msiebeling committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    6fc3400 View commit details
    Browse the repository at this point in the history

  5. Add travis.yml

    @fullsailor @msiebeling
    fullsailor authored and msiebeling committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    b1490d5 View commit details
    Browse the repository at this point in the history

  6. Update travis.yml release -> 1.6 

    I believe I was lied to. (or followed out of date advice)
    @fullsailor @msiebeling
    fullsailor authored and msiebeling committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    544cda0 View commit details
    Browse the repository at this point in the history

  7. Add build status to README

    @fullsailor @msiebeling
    fullsailor authored and msiebeling committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    a5d962c View commit details
    Browse the repository at this point in the history

  8. add support for aes128-CBC 

    OID 2.16.840.1.101.3.4.1.2
    @groob @msiebeling
    groob authored and msiebeling committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    7041c07 View commit details
    Browse the repository at this point in the history

  9. Support S/MIME detached signatures, and improve tests

    @jvehent @msiebeling
    jvehent authored and msiebeling committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    10edc64 View commit details
    Browse the repository at this point in the history

  10. Fix indefinite form parsing to parse nested indefinite form correctly.

    @addie9000 @msiebeling
    addie9000 authored and msiebeling committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    a2fc7ee View commit details
    Browse the repository at this point in the history

  11. Fix hardcoded signature algorithm for verifying signers 

    Since Go 1.10, the SignatureAlgorithm is now validated against the public key type. It was "working" before because the Amazon key used DSA with SHA1, and so the RSA/DSA mismatch didn't matter since the SHA1 hash type did.

This uses some unexported code from `crypto/x509` that looks up a signature algorithm for a given `pxix.AlgorithmIdentifier`

Fixes fullsailor#27
Fixes fullsailor#28
Fixes fullsailor#29
    @fullsailor @msiebeling
    fullsailor authored and msiebeling committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    fa02d36 View commit details
    Browse the repository at this point in the history

  12. Bump tested Go versions to include 1.9 & 1.10

    @fullsailor @msiebeling
    fullsailor authored and msiebeling committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    d0374ff View commit details
    Browse the repository at this point in the history

  13. Fix verifying App Store receipts 

    App Store receipts have an unusual DigestEncryptionAlgorithm, this may be because it doesn't have any authenticated attributes.

If the new strategy for determining the correct x509.SignatureAlgorithm fails, we fallback to the old SHA1WithRSA algo.
    @fullsailor @msiebeling
    fullsailor authored and msiebeling committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    6a48d77 View commit details
    Browse the repository at this point in the history

  14. Don't use asn1.NullBytes, its unavailable in Go 1.8

    @fullsailor @msiebeling
    fullsailor authored and msiebeling committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    917222b View commit details
    Browse the repository at this point in the history

  15. Test in Go 1.10, not Go 1.1

    @fullsailor @msiebeling
    fullsailor authored and msiebeling committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    6569da0 View commit details
    Browse the repository at this point in the history

  16. Don't use asn1.TagNull, it was also introduced in Go 1.9

    @fullsailor @msiebeling
    fullsailor authored and msiebeling committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    663621a View commit details
    Browse the repository at this point in the history

  17. Fix failure to parse enveloped data in Go 1.10 

    Go 1.10 is more strict about Asn.1 annotations. This removes the incorrect “explicit” annotation from encryptedContentInfo.EncryptedContent.

I’m also using openssl to generate the fixture now so that we aren’t testing with our own output for `Decrypt()`

Fixes fullsailor#31
    @fullsailor @msiebeling
    fullsailor authored and msiebeling committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    22bc924 View commit details
    Browse the repository at this point in the history

  18. Fix detached data content type 

    The content type should be oidData.

Fixes fullsailor#24
    @fullsailor @msiebeling
    fullsailor authored and msiebeling committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    720ab68 View commit details
    Browse the repository at this point in the history

  19. Add support for verifying SHA256 signer digest

    @ktezlaf @msiebeling
    ktezlaf authored and msiebeling committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    37e4b64 View commit details
    Browse the repository at this point in the history

  20. Comment out all lines with encodeIndent variable

    @lchudinov @msiebeling
    lchudinov authored and msiebeling committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    aa41f78 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2019

  1. Merge pull request #2 from sggms/georg/ch6977/esb-race-condition-dete… 

    …cted-when-running

Georg/ch6977/esb race condition detected when running
    @geoko86
    geoko86 authored Nov 27, 2019
    Configuration menu
    Copy the full SHA
    38a5ffa View commit details
    Browse the repository at this point in the history