Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade jquery version due to vulnerability #180

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lucasmilotichhf
Copy link

There are two vulnerabilities with jquery versions older than 3.5:
https://nvd.nist.gov/vuln/detail/CVE-2020-11022
https://nvd.nist.gov/vuln/detail/CVE-2020-11023

Copy link

@Taofeeqib Taofeeqib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The jQuery has been updated to the latest version (3.6.0) https://jquery.com/download/

Copy link

@Taofeeqib Taofeeqib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jQuery has been updated to the latest version (3.6.0) https://jquery.com/download/

@@ -329,7 +329,7 @@ var _bintree = &bintree{nil, map[string]*bintree{
"grpc-bg.svg": {grpcBgSvg, map[string]*bintree{}},
"grpc-logo.png": {grpcLogoPng, map[string]*bintree{}},
"index-template.html": {indexTemplateHtml, map[string]*bintree{}},
"jquery-3.4.1.min.js": {jquery341MinJs, map[string]*bintree{}},
"jquery-3.6.0.min.js": {jquery341MinJs, map[string]*bintree{}},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfamiliar with this code, but: this line still says jquery341MinJs?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed :)

@dragonsinth
Copy link
Member

Hmm... looking at this more, I think you're not supposed to just patch bindata.go directly. I think you're supposed to update the resources in go-bindata-all.sh?

Copy link

@spatecon spatecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But maybe bindata should be regenerated before merge by maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants