cleanup and refactor to follow code conventions

funkia · Sep 4, 2019 · f22b3af · f22b3af
1 parent 3a3cfd0
commit f22b3af
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 18 deletions.
diff --git a/src/behavior.ts b/src/behavior.ts
@@ -69,25 +69,22 @@ export abstract class Behavior<A> extends Reactive<A, BListener>
   }
   abstract update(t: number): A;
   pushB(t: number): void {
-    if (this.changedAt === t) {
-      // This prevents a second push with same timestamp, to be further pushed
-      return;
-    }
-    this.pull(t);
-    if (this.changedAt === t && this.state === State.Push) {
-      pushToChildren(t, this);
+    if (this.pulledAt !== t) {
+      this.pull(t);
+      if (this.changedAt === t && this.state === State.Push) {
+        pushToChildren(t, this);
+      }
     }
   }
   pull(t: number): void {
     if (this.pulledAt === undefined || this.pulledAt < t) {
       this.pulledAt = t;
       let shouldRefresh = this.changedAt === undefined;
       for (const parent of this.parents) {
-        if (!isBehavior(parent)) {
-          continue;
+        if (isBehavior(parent)) {
+          parent.pull(t);
+          shouldRefresh = shouldRefresh || this.changedAt < parent.changedAt;
         }
-        parent.pull(t);
-        shouldRefresh = shouldRefresh || this.changedAt < parent.changedAt;
       }
       if (shouldRefresh) {
         refresh(this, t);

diff --git a/src/common.ts b/src/common.ts
@@ -49,9 +49,7 @@ export class PushOnlyObserver<A> implements BListener, SListener<A> {
     }
   }
   pushB(t: number): void {
-    const b = <Behavior<A>>this.source;
-    b.pull(t);
-    this.callback(b.last);
+    this.callback((<Behavior<A>>this.source).last);
   }
   pushS(t: number, value: A): void {
     this.callback(value);
@@ -147,9 +145,7 @@ export class CbObserver<A> implements BListener, SListener<A> {
     }
   }
   pushB(t: number): void {
-    const b = <Behavior<A>>this.source;
-    b.pull(t);
-    this.callback(b.last);
+    this.callback((<Behavior<A>>this.source).last);
   }
   pushS(t: number, value: A): void {
     this.callback(value);

diff --git a/src/placeholder.ts b/src/placeholder.ts
@@ -54,7 +54,6 @@ export class Placeholder<A> extends Behavior<A> {
     if (this.source !== undefined) {
       this.source.addListener(this.node, t);
       if (isBehavior(this.source)) {
-        this.pull(t);
         this.last = this.source.last;
         this.changedAt = this.source.changedAt;
         this.pulledAt = this.source.pulledAt;