-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolveJsonModule not working #53
Comments
Sample error in studio, just to see that it works Option error goes away if I add the outDir {
"compilerOptions": {
"module": "commonjs",
"outDir": "",
"resolveJsonModule": true,
"esModuleInterop": true
},
"exclude": [
"node_modules"
]
} |
@jpike88 |
I think you're right, I'm going to close this for now and avoid it as it's a bit of an edge case anyway. This issue I'm following in TS, if that is implemented that would probably be what I'd use instead anyhow |
I think we should build in exemptions to omit this error. The problem is that outDir shouldn't need a value for this to do its job, which is just to check types. Files being written/not written shouldn't be a factor here. |
yes, we could add a option to skip ts errors, as a option. |
@jpike88 Can test it here: Tell me how it works out for you |
this solves the issue. eagerly awaiting release :D |
I get this error when turning on resolveJsonModule:
/Users/Me/Project/angularHelpers.ts (4,26) (Error:TS2307) Cannot find module './en-AU.json'
Can you confirm whether resolveJsonModule works for you at all?
Using TS 2.9.1, VSCode actually reports it as fine, and tsc has a weirder issue going on:
microsoft/TypeScript#24743
UPDATE: the weirder issue seems to be deliberate...
microsoft/TypeScript#24715
Thanks
The text was updated successfully, but these errors were encountered: