Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow rfc1034 like Fyne for package name. #154

Closed
wants to merge 1 commit into from
Closed

Follow rfc1034 like Fyne for package name. #154

wants to merge 1 commit into from

Conversation

Bluebugs
Copy link
Contributor

Description:

fyne-cross is not aware that fyne follow rfc1034 when packaging the application for ios. This PR correct that.

Checklist:

  • Tests all pass.

lucor
lucor reviewed Dec 28, 2022
View reviewed changes
Copy link
Member

@lucor lucor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd only add some tests for the output of the rfcLabel func, especially for the edge cases with . and Unicode chars. Apart that LGTM

@Bluebugs
Copy link
Contributor Author

This won't be necessary after merging #159 .

@Bluebugs Bluebugs closed this Dec 30, 2022
@Bluebugs Bluebugs deleted the bugs/ios-local-build branch December 30, 2022 21:35
@vboehr vboehr mentioned this pull request Jul 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucor lucor lucor left review comments

@andydotxyz andydotxyz Awaiting requested review from andydotxyz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bluebugs @lucor