Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added enum switch node #88

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Added enum switch node #88

wants to merge 1 commit into from

Conversation

nspielbau
Copy link
Contributor

@nspielbau nspielbau commented Jul 4, 2024

Fixes #33

Signed-off-by: Niklas Spielbauer <spielbauer@fzi.de>
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 27.65957% with 34 lines in your changes missing coverage. Please review.

Project coverage is 33.80%. Comparing base (adfad4a) to head (a2900ec).
Report is 2 commits behind head on dev.

Files Patch % Lines
ros_bt_py/ros_bt_py/nodes/fallback.py 27.65% 34 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #88      +/-   ##
==========================================
- Coverage   33.85%   33.80%   -0.06%     
==========================================
  Files          37       37              
  Lines        5461     5508      +47     
  Branches     1252     1267      +15     
==========================================
+ Hits         1849     1862      +13     
- Misses       3552     3586      +34     
  Partials       60       60              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 4, 2024

Test Results

 10 files  ±0   10 suites  ±0   27s ⏱️ ±0s
202 tests ±0  202 ✅ ±0  0 💤 ±0  0 ❌ ±0 
404 runs  ±0  404 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a2900ec. ± Comparison against base commit cf8dbda.

@Oberacda Oberacda self-requested a review July 4, 2024 11:35
@Oberacda Oberacda added enhancement New feature or request Nodes Issues concerning the standard node library. Medium Priority labels Jul 4, 2024
@Oberacda
Copy link
Contributor

Oberacda commented Jul 4, 2024

Can you please add tests for the node @nspielbau ?

@nspielbau nspielbau marked this pull request as draft July 4, 2024 11:38
@nspielbau nspielbau changed the title Added enum switch mode Added enum switch node Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Medium Priority Nodes Issues concerning the standard node library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants