-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: strip attributes outside of cargo-expand #1676
Conversation
d7e9f24
to
01d7e83
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1676 +/- ##
===========================================
- Coverage 99.26% 55.12% -44.14%
===========================================
Files 358 351 -7
Lines 14948 12703 -2245
===========================================
- Hits 14838 7003 -7835
- Misses 110 5700 +5590 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Only some nits and discussions
06ac6e5
to
baa304c
Compare
I've been having difficulties running precommit as it keeps deleting everything inside flutter_via_create/integrate, wonder if it's intermittent or something more serious that needs fixing. |
Curently the
Thus, if the template is outdated, it will be pasted and override the newly generated thing... This is suboptimal and maybe we can improve it, what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only a few nits :)
frb_codegen/src/library/codegen/generator/api_dart/spec_generator/class/field.rs
Show resolved
Hide resolved
Interesting, will check tomorrow what might make the template be outdated. |
Changes
#[cfg]
only when running cargo-expand to preserve FRB attributesCloses #1488
Closed #1720 (<- edited by @fzyzcjy)
Checklist
./frb_internal precommit --mode slow
(orfast
) is run (it internal runs code generator, does auto formatting, etc)../website
folder) are updated.Remark for PR creator
./frb_internal --help
shows utilities for development.