Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scopes[] to the FilteringTerm #109

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

redmitry
Copy link
Collaborator

@redmitry redmitry commented Sep 5, 2023

The patch is the response to the several discussions #93, #94.

beaconFilteringTermsResults.json FilteringTerm should provide a list of scopes (entryTypes) the filter may be applied,

Dmitry

@costero-e
Copy link
Collaborator

costero-e commented Sep 5, 2023

Everything looks fine except for the example, as we have discussed in person,
the json should look like this:

                    "examples": [
                        ["individual", "biosample"]
                    ],

The yaml looks good but without the commas.

@jrambla
Copy link
Contributor

jrambla commented Jan 9, 2024

It looks good to me.
Not to be corrected in this PR, but the example "Human Phenotype Ontology" is wrong as it is not part of the type enum.

@costero-e costero-e self-requested a review January 10, 2024 11:46
@costero-e costero-e merged commit e2d7941 into ga4gh-beacon:develop Jan 10, 2024
@costero-e costero-e modified the milestone: 2.1 Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants