Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres feature #83

Merged
merged 20 commits into from
Oct 26, 2023
Merged

Postgres feature #83

merged 20 commits into from
Oct 26, 2023

Conversation

alextsaihi
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Merging #83 (cab1551) into develop (92ba34a) will not change coverage.
The diff coverage is n/a.

❗ Current head cab1551 differs from pull request most recent head e011856. Consider uploading reports for the commit e011856 to get more accurate results

@@            Coverage Diff             @@
##             develop      #83   +/-   ##
==========================================
  Coverage      64.42%   64.42%           
  Complexity       241      241           
==========================================
  Files             51       51           
  Lines            894      894           
  Branches          60       60           
==========================================
  Hits             576      576           
  Misses           307      307           
  Partials          11       11           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alextsaihi
Copy link
Contributor Author

hi @dashrath-chauhan and @yash-puligundla , I've migrated the PR over to this one so that it is a branch of ga4gh/ga4gh-starter-kit-drs instead of a fork

old PR: #80

@alextsaihi
Copy link
Contributor Author

alextsaihi commented Oct 26, 2023

steps to test:

FROM POSTGRES

docker-compose up -d
from postgres container's terminal, psql -U postgres
\c starter_kit_db -> you should see "You are now connected to database starter_kit_db as user postgres"
\dt-> you should see 9 tables listed
\q (to exit postgres terminal)

FROM DRS
from Postman, GET the following urls:
http://localhost:4500/ga4gh/drs/v1/service-info
http://localhost:4500/ga4gh/drs/v1/objects/1a570e4e-2489-4218-9333-f65549495872

CLOSING TEST
stop postgres container and try a GET request again

README.md Outdated Show resolved Hide resolved
@yash-puligundla yash-puligundla merged commit 6be5688 into develop Oct 26, 2023
2 checks passed
@yash-puligundla yash-puligundla deleted the at-postgres-2 branch October 26, 2023 15:31
@yash-puligundla
Copy link
Member

Good work Alex! Everything works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants