-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaged for Nix #16
Comments
Adding a I need to start using nix as well. #17 sounds super intriguing, so I'd be in favor of it but I don't have enough nix experience to know where to start going with it. If there are garden features that make it easier to accomplish the integration then I'm all ears. Anyways, just saying that I'm very much in favor of nix-related topics. |
I've gotten this building via crane if you're interested in that approach https://github.com/firestack/garden-rs.nix I didn't look into why the |
Thanks @firestack that's really cool. As a non-nix user, what would be the best way to adopt the nix packaging into this repo if we wanted to maintain it in-tree? I noticed a few I'd be more than happy to merge a PR that adds a nix file to the repo if you're down to help maintain it and give me some guidance on what the installation instructions should look like in the documentation. Let me know if there's anything more I can do to help. And, yeah, sorry that I haven't had a chance to install or experiment with nix so I'm pretty unfamiliar with the tooling and nix dev workflow for upstream authors. |
Just a supportive note to add that we'll all still learning :) I've also previously created nix packaging using https://github.com/nix-community/nix-init but felt uncertain about recommending it for PR. As an incremental step, may we use an medium/long running feature branch for nix packaging? That way it's visible and iterable but without all the implicit guarantees of polish that a merged-to-main PR might suggest. Thanks @firestack, @davvid ! |
I can open a PR to add it and we can collaborate from there, limited free-time etc etc. If we use flakes (a hot topic in the community) we'd need to add a @nickgarber do you have any preferences on flakes?
Yes, this tells nix not to check for a
One thing that does come to mind is investigating how to make sure test's work correctly in nix. I think it's mostly straightforward, but just something to keep in mind for when there's a PR. |
I heavily and happily pro-flakes in my own work :D but also very aware that large swathes of this subject matter are new to me. Hoping to help and eager to learn! |
I got the test suite working in nix. It was mostly a matter of making I'll be pushing up commits shortly that resolve this issue but I'm still down for further tweaks and enhancements from more experienced nix users. |
Hello!
Would you be open to adding (or reviewing a PR for) the ability to install Garden as a Nix package?
If so, I'd be interested in contributing this or assisting with it.
It's possible and useful to make garden installable via Nix by adding a single (flake.nix) file to the root of this repo.
[1] https://nix-tutorial.gitlabpages.inria.fr/nix-tutorial/first-package.html
The text was updated successfully, but these errors were encountered: