Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Fix CRD health checks due to conversion errors #85

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Fix CRD health checks due to conversion errors #85

merged 1 commit into from
Nov 3, 2020

Conversation

timuthy
Copy link
Contributor

@timuthy timuthy commented Nov 2, 2020 •
edited
Loading

How to categorize this PR?

/area robustness
/kind bug
/priority normal

What this PR does / why we need it:
This PR fixes CRD health checks which only worked for CRDs of version v1beta1 and ran into conversion issues if v1 was present.

Co-authored-by: DockToFuture sebastian.stauch@sap.com

Release note:

An issue has been fixed which caused failing health checks for `CustomResourceDefinitions` of version `v1`.

@timuthy @DockToFuture
Fix CRD health checks due to conversion errors
630f038 
Co-authored-by: DockToFuture <sebastian.stauch@sap.com>
@timuthy timuthy requested a review from a team as a code owner November 2, 2020 13:57
@gardener-robot
Copy link
Contributor

@timuthy Labels area/todo, kind/todo do not exist.

@gardener-robot gardener-robot added priority/normal needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Nov 2, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 2, 2020
rfranzke
rfranzke approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging area/robustness Robustness, reliability, resilience related kind/bug Bug and removed needs/review Needs review labels Nov 2, 2020
timebertt
timebertt suggested changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally lgtm, just one comment :)

pkg/health/health_test.go Show resolved Hide resolved
@gardener-robot gardener-robot added needs/changes Needs (more) changes and removed reviewed/lgtm Has approval for merging labels Nov 2, 2020
@timebertt timebertt merged commit f628a50 into gardener-attic:master Nov 3, 2020
@timuthy timuthy deleted the fix.crd-healthcheck branch November 3, 2020 08:24
mwindower added a commit to metal-stack/gardener-extension-provider-metal that referenced this pull request Dec 10, 2020
@mwindower
use newer resource-manager that contains the PR gardener-attic/garden…
21e7b36 
…er-resource-manager#85
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rfranzke rfranzke rfranzke approved these changes

@timebertt timebertt timebertt approved these changes

Assignees
No one assigned
Labels
area/robustness Robustness, reliability, resilience related kind/bug Bug needs/changes Needs (more) changes needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@timuthy @gardener-robot @rfranzke @timebertt @gardener-robot-ci-2