Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to changes needed for gardener-node-agent #80

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Adapt to changes needed for gardener-node-agent #80

merged 4 commits into from
Nov 28, 2023

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Oct 26, 2023 •
edited
Loading

How to categorize this PR?

/area os
/kind enhancement

What this PR does / why we need it:
This PR adapts this extension to changes needed for gardener-node-agent, see gardener/gardener#8647 for more information.

Which issue(s) this PR fixes:
Part of gardener/gardener#8023

Special notes for your reviewer:
Kindly use the dedicated commits for an easier review process.

/cc @oliver-goetz @MrBatschner @danielfoehrKn

Release note:

This extension is now prepared to run with an enabled `UseGardenerNodeAgent` feature gate.

@rfranzke rfranzke requested review from a team as code owners October 26, 2023 11:56
@gardener-robot gardener-robot added needs/review Needs review area/os Operation system related kind/enhancement Enhancement, improvement, extension size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Oct 26, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 26, 2023
@rfranzke rfranzke mentioned this pull request Oct 26, 2023
Closed
55 tasks
@gardener gardener deleted a comment from gardener-robot Oct 26, 2023
@gardener gardener deleted a comment from gardener-robot Oct 26, 2023
@rfranzke
Copy link
Member Author

/hold
Let's wait with the merge for another revendoring with gardener/gardener@v1.83.0 containing gardener/gardener#8707

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Oct 27, 2023
@rfranzke
Rework directory restructure
ca3448a 
In the future, the `pkg/controller/operatingsystemconfig/coreos` package can be deleted entirely
@rfranzke
Revendor g/g to v1.84.0
401cfdf
@rfranzke
Adapt OSC controller
b893c4a 
- prepare for new OSC contract when `UseGardenerNodeAgent` feature gate is enabled
@rfranzke
Set UseGardenerNodeAgent option based on gardenlet feature gate
6ff9651
@rfranzke
Copy link
Member Author

/unhold
gardener/gardener@v1.84 has been released today, and this PR has been adapted accordingly.

/cc @MrBatschner @danielfoehrKn @oliver-goetz
I think it's ready to be merged now. Please proceed with the review, thank you!

@gardener-robot gardener-robot removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Nov 17, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 17, 2023
@rfranzke
Copy link
Member Author

Can we merge (and release?) this as well?

@MrBatschner MrBatschner merged commit 38ab898 into gardener:master Nov 28, 2023
5 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 28, 2023
@rfranzke rfranzke deleted the gna branch November 28, 2023 16:07
@rfranzke rfranzke mentioned this pull request Feb 23, 2024
Merged
@rfranzke rfranzke mentioned this pull request Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfoehrKn danielfoehrKn danielfoehrKn approved these changes

Assignees
No one assigned
Labels
area/os Operation system related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rfranzke @danielfoehrKn @MrBatschner @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot