-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support flatcar version >= 3815.2.0 #93
Support flatcar version >= 3815.2.0 #93
Conversation
@MichaelEischer Thank you for your contribution. |
Thank you @MichaelEischer for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
/add reviewed/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, just a minor suggestion on my side.
You cold also include in the TODO
comments which is the last version of flatcar that ships with torcx
.
@plkokanov I've updated the TODO comments as suggested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
@MichaelEischer Command |
@plkokanov Is there anything left to do here to get this PR merged? |
Would be great to get this merged and released. |
/cc @danielfoehrKn @marwinski if they would also like to have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
/lgtm
I suggest merging this by tomorrow if there is no additional feedback.
@timebertt Command |
How to categorize this PR?
/area os
/kind enhancement
What this PR does / why we need it:
Flatcar starting from version 3815.2.0 has removed torcx support and replaced it with systemd-sysext. The main difference form a user perspective is that the containerd binaries have moved from /run/torcx/unpack/docker/bin to /usr/bin .
This PR updates the extension to (still) prefer binaries in /run/torcx/unpack/docker/bin but to also fall back to /usr/bin if the former don't exit. This allows using both Flatcar versions that still use torcx and those that only use systemd-sysext.
Which issue(s) this PR fixes:
Special notes for your reviewer:
I've manually tested the change with flatcar 3760.2.0 and 3815.2.0. (although still using Gardener 1.79)
Release note: