Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only apply HA-ns webhook on HA type zone #801

Merged
merged 1 commit into from
Mar 4, 2024
Merged

only apply HA-ns webhook on HA type zone #801

merged 1 commit into from
Mar 4, 2024

Conversation

kon-angelo
Copy link
Contributor

How to categorize this PR?

/area control-plane
/kind bug
/platform azure

What this PR does / why we need it:
Fix an issue where the webhook was applied to namespaces other than those with HA type "zone"

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kon-angelo kon-angelo requested review from a team as code owners March 4, 2024 10:08
@gardener-robot gardener-robot added needs/review Needs review area/control-plane Control plane related kind/bug Bug platform/azure Microsoft Azure platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 4, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 4, 2024
ScheererJ
ScheererJ approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 4, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 4, 2024
@kon-angelo kon-angelo merged commit 2394a27 into gardener:master Mar 4, 2024
18 checks passed
@kon-angelo kon-angelo deleted the webhook-ha-ns branch March 4, 2024 10:27
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kon-angelo @ScheererJ @gardener-robot-ci-3 @gardener-robot