Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm meta-record deletion, update tests #802

Merged
merged 1 commit into from
Mar 20, 2024
Merged

rm meta-record deletion, update tests #802

merged 1 commit into from
Mar 20, 2024

Conversation

hebelsan
Copy link
Contributor

@hebelsan hebelsan commented Mar 5, 2024

How to categorize this PR?

/area networking
/kind cleanup
/platform azure

What this PR does / why we need it:
Removes old superfluous dns-metarecord deletion.

@hebelsan hebelsan requested review from a team as code owners March 5, 2024 08:17
@gardener-robot gardener-robot added area/networking Networking related kind/cleanup Something that is not needed anymore and can be cleaned up platform/azure Microsoft Azure platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 5, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 5, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 5, 2024
@kon-angelo
Copy link
Contributor

/invite @MartinWeindel

@AndreasBurger
Copy link
Member

/cla

@gardener-robot
Copy link

@AndreasBurger I reached out successfully to the cla-assistant to recheck this pull request.

MartinWeindel
MartinWeindel approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for cleaning up!

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 5, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 5, 2024
@kon-angelo kon-angelo merged commit c38090c into gardener:master Mar 20, 2024
18 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

Assignees
No one assigned
Labels
area/networking Networking related kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hebelsan @kon-angelo @AndreasBurger @gardener-robot @MartinWeindel @gardener-robot-ci-2 @gardener-robot-ci-3