Upgrade git-lfs to support local paths #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @kevinbreit-garmin! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2023-09-27 15:12:14 UTC |
kevinbreit-garmin
force-pushed
the
git-lfs-local-paths
branch
from
0afb6b9
to
b0b0bc6
Compare
This change upgrades git-lfs, in all images that used it, to a newer version that is at least 2.10 that supports local paths. This enables lfs with local remotes within the containers to function.
This adds a test of the git-lfs version to be at least 2.10, when local file path support was added.
kevinbreit-garmin
force-pushed
the
git-lfs-local-paths
branch
from
b0b0bc6
to
543516d
Compare
JoshuaWatt
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git-lfs support was added, but unfortunately versions before 2.10 don't support local paths.
This can make testing difficult with a bitbake recipe that points to a local path for testing, when that local repository uses LFS. To fix this, we can pull in newer versions of git-lfs like 16.04 had. To make sure git-lfs is new enough, add a test for it. The minimum git-lfs release is v2.10.