-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(create-gatsby): Respect telemetry disable
- Loading branch information
Showing
3 changed files
with
115 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
import { getConfigStore } from "../get-config-store" | ||
|
||
const mockGetFunction = jest.fn() | ||
const mockSetFunction = jest.fn() | ||
|
||
jest.mock(`../get-config-store`, () => { | ||
return { | ||
getConfigStore: (): unknown => { | ||
return { | ||
items: {}, | ||
set(key: string, value: unknown): void { | ||
mockSetFunction(key, value) | ||
;(this as any).items[key] = value | ||
}, | ||
get(key: string): unknown { | ||
mockGetFunction(key) | ||
return (this as any).items[key] | ||
}, | ||
|
||
__reset(): void { | ||
;(this as any).items = {} | ||
}, | ||
} | ||
}, | ||
} | ||
}) | ||
|
||
let isTrackingEnabled | ||
|
||
describe(`isTrackingEnabled`, () => { | ||
beforeEach(() => { | ||
jest.resetModules() | ||
isTrackingEnabled = require(`../tracking`).isTrackingEnabled | ||
}) | ||
|
||
afterEach(() => { | ||
jest.resetAllMocks() | ||
}) | ||
|
||
it(`is enabled by default`, async () => { | ||
const enabled = isTrackingEnabled() | ||
expect(enabled).toBe(true) | ||
expect(mockGetFunction).toHaveBeenCalledWith(`telemetry.enabled`) | ||
expect(mockSetFunction).toHaveBeenCalledWith(`telemetry.enabled`, true) | ||
}) | ||
|
||
// TODO - Implement remaining tests | ||
|
||
it.skip(`respects the setting of the config store`, async () => { | ||
const store = getConfigStore() | ||
store.set(`telemetry.enabled`, false) | ||
const enabled = isTrackingEnabled() | ||
expect(enabled).toBe(false) | ||
}) | ||
|
||
it.skip(`respects the setting of the environment variable`, async () => {}) | ||
|
||
it.skip(`caches the setting for all calls in create-gatsby`, async () => {}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
// TODO - Check if we want to add core utils as a dependency or not, | ||
// that's where this is taken from. | ||
|
||
// Returns true for `true`, true, positive numbers | ||
// Returns false for `false`, false, 0, negative integers and anything else | ||
export function isTruthy(value: any): boolean { | ||
// Return if Boolean | ||
if (typeof value === `boolean`) return value | ||
|
||
// Return false if null or undefined | ||
if (value === undefined || value === null) return false | ||
|
||
// If the String is true or false | ||
if (value.toLowerCase() === `true`) return true | ||
if (value.toLowerCase() === `false`) return false | ||
|
||
// Now check if it's a number | ||
const number = parseInt(value, 10) | ||
if (isNaN(number)) return false | ||
if (number > 0) return true | ||
|
||
// Default to false | ||
return false | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters