Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0] using-remark: preload fonts used on the homepage #1256

Merged
merged 2 commits into from
Jun 27, 2017

Conversation

fk
Copy link
Contributor

@fk fk commented Jun 25, 2017

Wondering if we should also preload the italic "Spectral" variants and/or "Space Mono" – both are only in use on non-index-routes? I recall Chrome complaining (in the developer console) if a font that is not used on the current page is set to be preloaded; not too familiar with preload yet … ;)

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jun 25, 2017

Deploy preview ready!

Built with commit 0139a8e

https://deploy-preview-1256--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jun 25, 2017

Deploy preview ready!

Built with commit 0139a8e

https://deploy-preview-1256--gatsbygram.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jun 25, 2017

Deploy preview ready!

Built with commit 0139a8e

https://deploy-preview-1256--gatsbyjs.netlify.com

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Jun 25, 2017 via email

@fk
Copy link
Contributor Author

fk commented Jun 25, 2017 via email

@fk
Copy link
Contributor Author

fk commented Jun 27, 2017

@KyleAMathews Good to go now!

@KyleAMathews KyleAMathews merged commit 0ce9432 into gatsbyjs:1.0 Jun 27, 2017
@KyleAMathews
Copy link
Contributor

@KyleAMathews
Copy link
Contributor

Great, thanks!

@fk
Copy link
Contributor Author

fk commented Jun 27, 2017

;)✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants