-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create deploy-gatsby.md #1480
Create deploy-gatsby.md #1480
Conversation
Deploy preview ready! Built with commit 20587b4 |
Deploy preview ready! Built with commit 20587b4 |
Deploy preview ready! Built with commit 20587b4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
deploy-gatsby.md
Outdated
## Best Practice | ||
|
||
|
||
Though you can deploy from the same location multiple times it is recommended that you clear your public directory before each build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the recommended practice actually. The only thing that needs deleted between builds is html files of pages that don't exist anymore.
You actually want to keep old builds around because when deploying often, people with your site open can still pull JS/Assets from their particular version of your site.
deploy-gatsby.md
Outdated
because this is going to be executed on every deploy it is suggested that you use an `package.json` script to simplify this process | ||
|
||
|
||
## Providers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps just link to a number of static hosts? There's no reason to prioritize Surge + it'll be perhaps hard for us to keep installation instructions up-to-date. Better I'd think to just send people off the hosting site?
Deploy preview failed. Built with commit 20587b4 https://app.netlify.com/sites/using-styled-components/deploys/596667597960b14dcba09c82 |
deploy-gatsby.md
Outdated
or alternatively | ||
`Uncaught Error: Minified React error #32; visit http://facebook.github.io/react/docs/error-decoder.html?invariant=32&args[]=## for the full message or use the non-minified dev environment for full errors and additional helpful warnings.` | ||
|
||
This is a new problem when dealing with static sites built with react. React uses comments to help identify locations of components that render do not render anything. If you are using a CDN that minifies your HTML it will eliminate the comments used by react to take control of the page on the client. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- React should be capitalized
- Say "HTML comments" not "comments"
- Comma after "your HTML".
Looking great! And one more thing I forgot. You need to add a link to the post in https://github.com/gatsbyjs/gatsby/blob/master/www/src/pages/docs/doc-links.yaml so it'll show up in the docs navigation. |
Is there a particular location that you want it to be located... since it is still in its infancy it appears to fit in most of those locations. |
How about the quick start section. The general guidelines for this right now is general help that 80%+ would want to read goes in quick start and more specific stuff goes in guides. |
And done. |
remove additional render
Alright take a look now. I think that was everything. |
Hiya @couturecraigj! 👋 This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here. Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! 💪💜 |
So I wrote something up for deploying gatsby. If you want to take a look and make suggestions on other sections or changes let me know. I will get it written up. Any other issues or bugs that we should inform people about would be helpful too.