RequireFallback function for requiring userland code

[nickmaltsev]

#1795

[jquense]

I don't think you can abstract this actually. Webpack statically analyzes requires, if the require path is completely dynamic the chances of stuff going wrong are high. like it including ALL files in the root in the bundle

[nickmaltsev]

Didn't know about these webpack features. So, seems like the only way here is to add e.code !== MODULE_NOT_FOUND checking for each try/catch block?

[jquense]

for any require in cache-dir yes, you can rescope the helper to contain the check and throw if you want though. but you need to do the require with string literals

[KyleAMathews]

Deploy preview failed.

Built with commit e9bd386

https://app.netlify.com/sites/using-glamor/deploys/5991f8156f4c5071551d7008

[KyleAMathews]

Working on a PR for this exact issue right now actually :-)

And yeah, as @jquense said, you need to require the fallback module in the catch.

Also checking for MODULE_NOT_FOUND won't work I've learned as the module you're requiring requires a non-existent module then the code will still be MODULE_NOT_FOUND. Turns out the only foolproof way is do a regex check of the error string 🤷‍♂️

[KyleAMathews]

Thanks for looking into this! Will be reviewing your other PRs soon!