fix(gatsby): Fixes incorrect type #31358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LekoArts
added
the
topic: TypeScript
gatsbot
bot
added
the
status: triage needed
LekoArts
removed
the
status: triage needed
LekoArts
commented
May 11, 2021
| @@ -251,7 +251,8 @@ | |||
| "prebuild": "rimraf dist && rimraf cache-dir/commonjs", | |||
| "postinstall": "node scripts/postinstall.js", | |||
| "prepare": "cross-env NODE_ENV=production npm run build", | |||
| "watch": "rimraf dist && mkdir dist && npm run build:internal-plugins && npm run build:rawfiles && npm run build:src -- --watch" | |||
| "watch": "rimraf dist && mkdir dist && npm run build:internal-plugins && npm run build:rawfiles && npm run build:src -- --watch", | |||
| "typecheck": "tsc --noEmit" | |||
There was a problem hiding this comment.
For easier checking with a modified tsconfig
LekoArts
commented
May 11, 2021
| @@ -12,7 +12,6 @@ | |||
| "strictFunctionTypes": true, | |||
| "strictPropertyInitialization": true, | |||
| "noFallthroughCasesInSwitch": true, | |||
| "skipLibCheck": true, | |||
wardpeet
approved these changes
May 11, 2021
vladar
pushed a commit
that referenced
this pull request
May 11, 2021
(cherry picked from commit f629806)
vladar
pushed a commit
that referenced
this pull request
May 11, 2021
axe312ger
pushed a commit
that referenced
this pull request
May 20, 2021
This was referenced Mar 13, 2022
This was referenced Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up of #30819
The error wasn't caught because of: #31324 (comment)
Related Issues
Fixes #31324