Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-plugin-styled-components): Add ability to disable vendor prefixes #33147

Merged
merged 5 commits into from
Sep 11, 2021

Conversation

herecydev
Copy link
Contributor

Description

Adds the ability to ignore vendor prefixing. Ideally autoprefixer would be used to generate the correct prefixes for the browsers that are supplied using browserslist, however this seems complicated to do as styled components uses stylis. Stylis goes "all in" on prefixes which can generate a lot of noise in css.

Documentation

Added some docs into the readme and in the joi schema

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 11, 2021
@herecydev herecydev changed the title Topic/sc vendor prefixing feat(gatsby-plugin-styled-components): Add ability to disable vendor prefixes Sep 11, 2021
wardpeet
wardpeet previously approved these changes Sep 11, 2021
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/gatsby-plugin-styled-components/src/gatsby-ssr.js Outdated Show resolved Hide resolved
@wardpeet wardpeet added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: plugins-styling Relates to the styling (e.g. CSS-in-JS, SASS, PostCSS) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Sep 11, 2021
@wardpeet wardpeet merged commit 3d05986 into gatsbyjs:master Sep 11, 2021
@herecydev herecydev deleted the topic/SCVendorPrefixing branch September 11, 2021 19:30
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
…prefixes (gatsbyjs#33147)

Co-authored-by: Ward Peeters <ward@coding-tech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: plugins-styling Relates to the styling (e.g. CSS-in-JS, SASS, PostCSS)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants