fix(gatsby): fix hydration flicker on initial render of ssr page for more cases #33196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: render-mode
pieh
changed the title
vladar
approved these changes
Sep 15, 2021
pieh
commented
Sep 15, 2021
| @@ -506,7 +506,7 @@ export class ProdLoader extends BaseLoader { | |||
| super(loadComponent, matchPaths) | |||
|
|
|||
| if (pageData) { | |||
| this.pageDataDb.set(pageData.path, { | |||
| this.pageDataDb.set(findPath(pageData.path), { | |||
There was a problem hiding this comment.
just for ref - this is how we fill pageData cache -
gatsby/packages/gatsby/cache-dir/loader.js
Lines 191 to 202 in fa70491
pagePath as key which is result of findPath(rawPath), and prewarming cache should use cache key produced with same method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#33134 worked if pagePath matches "normalizedPath". This make sure we store it under normalize key when prewarming pageData cache.
I do think this will cause troubles withWon't cause problems withmatchPathcases, so PR is draft for now until I do discovery on that (I don't want make it worse!)matchPathbecause ofrequires-writerskipping non-ssg matchPath pages (and tested locally)[ch38318]