Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-dev-cli): Do not ignore engines #34461

Merged
merged 1 commit into from
Jan 12, 2022
Merged

fix(gatsby-dev-cli): Do not ignore engines #34461

merged 1 commit into from
Jan 12, 2022

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Jan 12, 2022 •
edited
Loading

Description

Partially revert #28464 with its ignore-engines change. Should hopefully catch breaking engines changes like in #33786

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 12, 2022
@LekoArts LekoArts added topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 12, 2022
@LekoArts LekoArts merged commit 822c6ca into master Jan 12, 2022
@LekoArts LekoArts deleted the do-not-ignore-engines branch January 12, 2022 12:52
moonmeister added a commit to moonmeister/gatsby that referenced this pull request Jan 12, 2022
@moonmeister
Merge branch 'master' into fix/validate/warnonunknown
73f68ea 
* master:
  fix(gatsby-core-utils): Re-Export updateSiteMetadata (gatsbyjs#34462)
  fix(deps): update starters and examples gatsby packages to ^4.5.1 (gatsbyjs#34463)
  fix(gatsby-dev-cli): Do not ignore engines (gatsbyjs#34461)
  fix(gatsby): Revert gatsbyjs#33786 (gatsbyjs#34458)
  fix(deps): update starters and examples - gatsby (gatsbyjs#34449)
  chore(changelogs): update changelogs (gatsbyjs#34451)
  Update tutorial part 1 to reflect changes to add site flow (gatsbyjs#34427)
  preview 2.0 UI changes (gatsbyjs#34440)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

Assignees
No one assigned
Labels
topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LekoArts @wardpeet