Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-source-contentful): avoid confusion of Gatsby node and Contentful node count in logs #34830

Merged
merged 1 commit into from
Feb 17, 2022
Merged

fix(gatsby-source-contentful): avoid confusion of Gatsby node and Contentful node count in logs #34830

merged 1 commit into from
Feb 17, 2022

Conversation

axe312ger
Copy link
Collaborator

In #34584 we improved logging to separate between new and updated nodes.

For the existing ones, we forgot to divide by locale count. As multiple existing Gatsby nodes reflect one single Contentful node, this should make it more clear how many Contentful nodes the system already knew on a warm build.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 16, 2022
TylerBarnes
TylerBarnes approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@TylerBarnes TylerBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense since a node in each locale is for the same content, right?

@LekoArts LekoArts added topic: source-contentful Related to Gatsby's integration with Contentful and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 17, 2022
@LekoArts LekoArts changed the title fix(contentful): avoid confusion of Gatsby node and Contentful node count in logs fix(gatsby-source-contentful): avoid confusion of Gatsby node and Contentful node count in logs Feb 17, 2022
@LekoArts LekoArts merged commit ac1d777 into master Feb 17, 2022
@LekoArts LekoArts deleted the fix/contentful-avoid-confusion-with-node-duplication branch February 17, 2022 08:04
@axe312ger
Copy link
Collaborator Author

@TylerBarnes correct!

This was referenced May 26, 2022
Open
Open
Open
This was referenced May 26, 2022
Open
Open
Open
This was referenced May 26, 2022
Open
Open
@0xSebin 0xSebin mentioned this pull request May 26, 2022
Open
@saurabharch saurabharch mentioned this pull request May 26, 2022
Open
@MaxMood96 MaxMood96 mentioned this pull request May 26, 2022
Open
This was referenced May 26, 2022
Open
Open
@MaxMood96 MaxMood96 mentioned this pull request May 26, 2022
Open
This was referenced May 26, 2022
Open
Open
Open
Open
@kaocher82 kaocher82 mentioned this pull request May 27, 2022
Open
@0xSebin 0xSebin mentioned this pull request May 27, 2022
Open
@Rutam21 Rutam21 mentioned this pull request May 27, 2022
Open
@0xSebin 0xSebin mentioned this pull request May 28, 2022
Open
This was referenced May 28, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request May 28, 2022
Open
@ajesse11x ajesse11x mentioned this pull request May 28, 2022
Open
@saurabharch saurabharch mentioned this pull request May 28, 2022
Open
@0xSebin 0xSebin mentioned this pull request May 28, 2022
Open
@MaxMood96 MaxMood96 mentioned this pull request May 28, 2022
Open
@0xSebin 0xSebin mentioned this pull request May 28, 2022
Open
This was referenced May 28, 2022
Open
Open
@nidhi42 nidhi42 mentioned this pull request May 28, 2022
Open
@ajesse11x ajesse11x mentioned this pull request May 29, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 5, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Jun 22, 2022
Open
@saurabharch saurabharch mentioned this pull request Jun 22, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Jun 22, 2022
Open
This was referenced Jul 21, 2022
Open
Open
@ajesse11x ajesse11x mentioned this pull request Aug 24, 2022
Open
@monizb monizb mentioned this pull request Feb 16, 2023
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 18, 2023
Merged
@0xSebin 0xSebin mentioned this pull request Feb 28, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Mar 16, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Mar 17, 2023
Open
This was referenced Mar 28, 2023
Open
Open
@kaocher82 kaocher82 mentioned this pull request May 12, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request May 23, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jun 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerBarnes TylerBarnes TylerBarnes approved these changes

Assignees
No one assigned
Labels
topic: source-contentful Related to Gatsby's integration with Contentful
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axe312ger @TylerBarnes @LekoArts