Clarify and optimize "Adding markdown pages" docs #3512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for gatsbygram ready! Built with commit 5559794 |
|
Hey! Thanks for the PR! This isn't actually a pattern we encourage. It's better to have the query in the component as then the component is self-contained & self-documented & easy to modify if e.g. you want to add/remove a field. Agree that the duplication isn't needed — could you instead remove all the unnecessary fields in gatsby-node.js? |
|
Oh ok, I understand. This one should maybe get updated then because it uses the opposite pattern. I will open a PR to remove the unused fields in gatsby-node.js! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of duplicating the query (once when creating the page, and once in the template), make use of context to pass the data we already have.