fix(gatsby-script): Reach router import #36385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
tyhopp
removed
the
status: triage needed
LekoArts
added
the
topic: DX
LekoArts
approved these changes
Aug 15, 2022
marvinjude
pushed a commit
that referenced
this pull request
Aug 16, 2022
(cherry picked from commit 4c752d1)
marvinjude
pushed a commit
that referenced
this pull request
Aug 16, 2022
This was referenced Aug 16, 2022
This was referenced Aug 16, 2022
This was referenced Dec 26, 2022
This was referenced Nov 27, 2023
This was referenced Nov 27, 2023
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Import our Reach Router fork the same way we do in Gatsby Link. Originally used the other import because it appeared to not use the same module as Gatsby core otherwise.
Also adds Reach Router as a peer dependency.
Documentation
N/A
Related Issues
N/A