Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphiql-explorer): Adjust env var truthiness logic #37032

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

tyhopp
Copy link
Contributor

@tyhopp tyhopp commented Nov 14, 2022

Description

Allow refresh endpoint in GraphiQL explorer to be enabled with ENABLE_GATSBY_REFRESH_ENDPOINT=true, currently only works with ENABLE_GATSBY_REFRESH_ENDPOINT=1 due to the unary plus.

Briefly tried adding gatsby-core-utils as a dep to use the isTruthy util, but that didn't work for some reason so I added a limited version of the logic instead.

Documentation

Related Issues

Fixes #37002

@tyhopp tyhopp added the topic: GraphQL Related to Gatsby's GraphQL layer label Nov 14, 2022
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 14, 2022
@tyhopp tyhopp removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 14, 2022
@tyhopp tyhopp merged commit 19dd1c4 into master Nov 14, 2022
@tyhopp tyhopp deleted the fix-graphiql-env-var-truthiness branch November 14, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: GraphQL Related to Gatsby's GraphQL layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gatsby v5 graphiql missing ENABLE_GATSBY_REFRESH_ENDPOINT feature.
2 participants