Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-source-drupal): await async handleDeletedNode #37435

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

TylerBarnes
Copy link
Contributor

@TylerBarnes TylerBarnes commented Jan 10, 2023

This async function isn't being awaited. I have a theory this is causing a problem for large sites (or maybe for all sites randomly) but I haven't verified that. This should be awaited either way though so should be good to merge.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 10, 2023
@TylerBarnes TylerBarnes added topic: source-drupal Related to Gatsby's integration with Drupal and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 10, 2023
@TylerBarnes TylerBarnes added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 10, 2023
@TylerBarnes TylerBarnes merged commit e575a0a into master Jan 10, 2023
@TylerBarnes TylerBarnes deleted the fix/delete-race-condition branch January 10, 2023 23:45
tyhopp pushed a commit that referenced this pull request Jan 13, 2023
await async handleDeletedNode

(cherry picked from commit e575a0a)
tyhopp pushed a commit that referenced this pull request Jan 13, 2023
await async handleDeletedNode

(cherry picked from commit e575a0a)
tyhopp pushed a commit that referenced this pull request Jan 13, 2023
…7458)

await async handleDeletedNode

(cherry picked from commit e575a0a)

Co-authored-by: Tyler Barnes <tylerdbarnes@gmail.com>
tyhopp pushed a commit that referenced this pull request Jan 13, 2023
…7461)

await async handleDeletedNode

(cherry picked from commit e575a0a)

Co-authored-by: Tyler Barnes <tylerdbarnes@gmail.com>
@pieh
Copy link
Contributor

pieh commented Jan 13, 2023

Published in:

  • gatsby-source-drupal@6.4.1
  • gatsby-source-drupal@5.26.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: source-drupal Related to Gatsby's integration with Drupal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants