feat(gatsby-source-drupal): drupal langcode as notlangcode #37445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
smthomas
previously approved these changes
Jan 11, 2023
| } | ||
|
|
||
| type Options = { | ||
| // TODO: type all options |
There was a problem hiding this comment.
Do we want to keep this comment in here as a reminder?
There was a problem hiding this comment.
I wanted to make sure it's obvious the full options aren't typed yet. I can follow up in another PR with types for this
TylerBarnes
added
topic: source-drupal
kathmbeck
approved these changes
Jan 11, 2023
sophiemcgarity
approved these changes
Jan 11, 2023
TylerBarnes
added
the
bot: merge on green
tyhopp
pushed a commit
that referenced
this pull request
Jan 13, 2023
* add ts support * make all files ts * add new enabled languages plugin option object types/docs * add local test scripts * add normalization code for langCode as def * use proper joi method name * change property name * refactor for TS * ts changes * ts fixes * use renamed code in node id * attempt to disable easlint rules for source-drupal (cherry picked from commit 3e8bb5a)
This was referenced May 26, 2023
This was referenced May 26, 2023
This was referenced May 26, 2023
This was referenced May 27, 2023
This was referenced May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The langcode in Drupal is renameable and this PR adds an option to configure using a renamed langcode in source-drupal.
While I was in there changing things I converted the project to TS - but that was mostly just renaming files and adding babel ts