Fix plugins not running gatsby-browser.js
#4329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
validateDOMNesting(...): <div> cannot appear as a descendant of <p>
ghost
assigned 
|
Deploy preview for gatsbygram ready! Built with commit 1a7ca1d |
|
Yeah, that sounds pretty reasonable. Thanks for tracking this down and fixing it! Also... Travis is weirdly not reported back that it's succeeded. Anyways, it did, I checked :-D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the recent changes in plugin loading, Gatsby will no longer run a
gatsby-browser.jsfile that doesn't export any Gatsby APIs.This was affecting a couple of plugins which I've fixed up in this PR, along with some tweaks to the Using Remark example site.
There's room for further improvement here, as silently ignoring a plugin file is not very helpful. My suggestion is that when loading a plugin, Gatsby should show a warning for any
gatsby-browser.js,gatsby-node.jsorgatsby-ssr.jsfiles that exist, but don't export any valid APIs. Does that sound sensible? Is there a better approach?Closes #4318