Upgrade plugin for styletron to v4.0 #4366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for gatsbygram ready! Built with commit bd6c5cf |
|
This would be a breaking change for the plugin since you have to install a number of new peerDependencies correct? |
|
The functions used in the using-styletron example remains the same, but yes, the dependencies are completely different. |
|
Ok, yeah. Since that'd break someone's site when upgrade gatsby-plugin-styletron, please bump the plugin version to 2.0.0 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the Styletron v3 to v4 Migration Guide, this upgrades styletron from v3 to v4. The gatsby example
using-styletron(aside from updating the dependencies), continues to work without code changes.