Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Update netlify-cms plugin to work in v2. #6056

Closed
wants to merge 1 commit into from

Conversation

richtera
Copy link

This currently works fine when using "gatsby develop" but fails in production when using "gatsy build".
In a production site the cms code is affected by the webpackJsonP wrappings and dynamic loading.
I added a template to specify the config file location and define a page context to make the script loader happy.

@erquhart Can you please look at this. I think there is a little more work to make this work in production mode along with the other webpackJsonP modules.

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jun 20, 2018

Deploy preview for using-drupal ready!

Built with commit 9aef740

https://deploy-preview-6056--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jun 20, 2018

Deploy preview for gatsbygram ready!

Built with commit 9aef740

https://deploy-preview-6056--gatsbygram.netlify.com

This currently works fine when using "gatsby develop" but fails in production when using "gatsy build".
In a production site the cms code is affected by the webpackJsonP wrappings and dynamic loading.
I added a template to specify the config file location and define a page context to make the script loader happy.
@shaunbent
Copy link
Contributor

Is there any update on the progress of this PR? This is a blocker on me upgrading my project to V2.

@ascorbic
Copy link
Contributor

ascorbic commented Jul 5, 2018

There's another PR (#6292) that apparently works, though I haven't tried it myself yet.

@m-allanson
Copy link
Contributor

Thanks @richtera! It looks like this is being handled over in #6292 if you want to look at reviewing that?

@m-allanson m-allanson closed this Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants