-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[offline-plugin] Add support for SW caching of prefetched resources #6566
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0d8eabe
remove babel compiled file
kkemple 4fe78a0
refactor: change how we process prefetches after SW install, clean up…
kkemple 399b435
fix: make sure we don't cache xml
kkemple 3de5990
Small copy tweak
KyleAMathews 4f4389f
refactor: minor cleanup
kkemple c50ff4c
minor cleanup
kkemple 9324b6b
fix: pass sw instance to all sw events
kkemple File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,3 +2,4 @@ | |
/gatsby-ssr.js | ||
/gatsby-browser.js | ||
/app-shell.js | ||
/prefetch-catcher.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,45 @@ | ||
exports.registerServiceWorker = () => true | ||
|
||
let swNotInstalled = true | ||
const pathnameResources = [] | ||
|
||
exports.onPrefetchPathname = ({ pathname, getResourcesForPathname }) => { | ||
// if SW is not installed, we need to record any prefetches | ||
// that happen so we can then add them to SW cache once installed | ||
if (swNotInstalled && `serviceWorker` in navigator) { | ||
pathnameResources.push( | ||
new Promise(resolve => { | ||
getResourcesForPathname(pathname, resources => { | ||
resolve(resources) | ||
}) | ||
}) | ||
) | ||
} | ||
} | ||
|
||
exports.onServiceWorkerInstalled = () => { | ||
// stop recording prefetch events | ||
swNotInstalled = false | ||
|
||
// grab nodes from head of document | ||
const nodes = document.querySelectorAll( | ||
`head > script[src], head > link[as=script]` | ||
) | ||
|
||
// get all script URLs | ||
const scripts = [].slice | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ol' skool dom hacking There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 😎 |
||
.call(nodes) | ||
.map(node => (node.src ? node.src : node.href)) | ||
|
||
// loop over all resources and fetch the page component and JSON | ||
// thereby storing it in SW cache | ||
Promise.all(pathnameResources).then(pageResources => { | ||
pageResources.forEach(pageResource => { | ||
const [script] = scripts.filter(s => | ||
s.includes(pageResource.page.componentChunkName) | ||
) | ||
fetch(pageResource.page.jsonURL) | ||
fetch(script) | ||
}) | ||
}) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could use a comment to explain that here we record resources that are prefetched before the sw has been installed and can cache things directly.